-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs/clarify static lease register #8028
Docs/clarify static lease register #8028
Conversation
@@ -63,6 +63,7 @@ | |||
<type>checkbox</type> | |||
<help> | |||
<![CDATA[If this option is set, then DHCP static mappings will be registered in Unbound, so that their name can be resolved. | |||
DHCP lease without a specified static ip cannot be register. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Static mappings are not leases. IP addresses are more or less implied for DNS to resolve but clarifying it in the first sentence wouldn’t hurt I suppose for all those who do read…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does DHCP static mapping which doesn't contain a static ip will not be registered
sound more accurate ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You want to make it affirmative:
… static mappings with an IP address will be registered…
6586a65
to
607e32a
Compare
timeout |
My bad sorry, i had other thing rise and completely forgot about this.... |
@Vaarlion no worries. appreciate the PR and discussion yet sometimes we also have to discuss and wait for similar reports for these types of suggestions.. sometimes documentation also makes sense.. here it looks like it's ok as is. |
Add some documentation to clarify #7990
I could not run the test on my computer, the makefile being for BSD system.
I'm hopping for an internal CI on your side ?